Received: (from majordom@localhost) by hyperreal.org (8.8.5/8.8.5) id UAA23712; Fri, 12 Sep 1997 20:05:24 -0700 (PDT) Received: from twinlark.arctic.org (twinlark.arctic.org [204.62.130.91]) by hyperreal.org (8.8.5/8.8.5) with SMTP id UAA23705 for ; Fri, 12 Sep 1997 20:05:21 -0700 (PDT) Received: (qmail 16879 invoked by uid 500); 13 Sep 1997 03:06:40 -0000 Date: Fri, 12 Sep 1997 20:06:40 -0700 (PDT) From: Dean Gaudet To: new-httpd@apache.org Subject: [PATCH] PR#1049: name-based, multi-port servers don't work Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org Yeah yeah I said I gave up on this code. I lied. Under discussion is the port test at the top of check_hostaliases. In 1.3 with this port test, name-based vhosts can only work if they are on the same port as the main server, requests on other ports always go to the main server (or a _default_). Without the test, name-based vhosts work on any port (but still must have the same ip as the main server). The main server will still pick up all otherwise unmatched hits (unless there's a _default_ host on that port). Removing the test is a good thing IMHO. It's pretty much the same in 1.2 with some weirdness due to the weirdness of * and _default_ handling. Removing the test is a good thing still. So I'm proposing it for 1.2 as well. Note that there are port tests further on to make sure the server selected really should live on the port claimed by the Host: header. Dean Index: http_protocol.c =================================================================== RCS file: /export/home/cvs/apachen/src/main/http_protocol.c,v retrieving revision 1.161 diff -u -r1.161 http_protocol.c --- http_protocol.c 1997/09/12 18:56:02 1.161 +++ http_protocol.c 1997/09/13 02:51:05 @@ -762,9 +762,6 @@ int l; server_rec_chain *src; - if (port && (port != r->server->port)) - return; - l = strlen(host)-1; if ((host[l]) == '.') { host[l] = '\0';