httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: Shortcomings in Makefiles
Date Mon, 22 Sep 1997 20:14:14 GMT
This won't work with make -j ... but I'm OK with it. 

make -j is kind of annoying to support in some cases. 

Dean

On Mon, 22 Sep 1997, Paul Sutton wrote:

> On Fri, 19 Sep 1997, Martin Kraemer wrote:
> > * modules.c is being compiled before the descent into the appropriate
> >   os/{unix,...} directory. The compilation therefore fails on a freshly
> >   unpacked apache source tree, since at that moment os*.[ch] are still
> >   missing from the include path. This could either be solved by
> >   additional -Ios/{unix,...} include statements, or better by visiting
> >   the os/{unix,...} directory first so that it will initialize
> >   main/os*.[ch]
> 
> Yeah, good point. Here is a simple patch to build modules.o last
> 
> Index: Makefile.tmpl
> ===================================================================
> RCS file: /export/home/cvs/apachen/src/Makefile.tmpl,v
> retrieving revision 1.65
> diff -u -r1.65 Makefile.tmpl
> --- Makefile.tmpl	1997/09/12 13:35:27	1.65
> +++ Makefile.tmpl	1997/09/22 18:08:02
> @@ -26,7 +26,7 @@
>  	@echo "If not, you will at least have to touch @@Configuration@@."
>  	@false
>  
> -httpd:  modules.o subdirs
> +httpd:  subdirs modules.o
>  	rm -f buildmark.c
>  	echo 'const char SERVER_BUILT[] = "'`date`'";' > buildmark.c
>  	$(CC) -c $(CFLAGS) buildmark.c
> 
> > * os/{unix,...}/Makefile still copies os*.[ch] to main/, instead of
> >   setting symlinks.
> 
> I've already posted a patch to do this. I don't think we need to worry
> about falling back to hard links though, since every variant of the
> os/unix platform supports symbolic links. The only platforms which do
> not support symlinks are OS/2 and Win32, and they both use different
> os/* directories.
> 
> > * The module depencencies could/should be checked; possibly, a
> >   dependency of more include files would be useful. Currently, only
> >   mod_speling depends on os.h
> 
> Um, yeah.
> 
> //pcs
> 
> 


Mime
View raw message