httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [Silence on the list?] Coding Style Questions
Date Wed, 17 Sep 1997 17:03:26 GMT


On Wed, 17 Sep 1997, Martin Kraemer wrote:

> [Wow! Not a single message today? What's going on? Hyperreal down? Or my
> company?]

Yeah I know, I was wondering myself :)

>       Either:                                Or:
>       =======                               =====
> 
>   port = 80;                        port = DEFAULT_PORT;
> 
>   return DOCUMENT_FOLLOWS;          return HTTP_OK;
>   return REDIRECT;                  return HTTP_MOVED_TEMPORARILY;
>       etc.                              etc.
> 

New code should be in the style of the second column.

> 				    #define HTTP_PROTO(major,minor) (1000*(major)+(minor))
>   if (r->proto_num >= 1001) ...     if (r->proto_num >= HTTP_PROTO(1,1))
...

This wouldn't be a bad change at all...

Dean


Mime
View raw message