httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Behlendorf <br...@organic.com>
Subject Re: mod_imap blocks non-GET methods (fwd)
Date Mon, 22 Sep 1997 17:30:42 GMT

+1.

At 11:41 PM 9/19/97 +0100, you wrote:
>
>
>this sounds reasonable.
>
>not acked
>
>---------- Forwarded message ----------
>Date: Fri, 19 Sep 1997 15:59:27 -0400 (EDT)
>From: Jay Bloodworth <jay@pathways.sde.state.sc.us>
>To: apache-bugs@apache.org
>Subject: mod_imap blocks non-GET methods
>
>mod_imap.c does not check the method of the request it is called with to
>ensure that it is get.  I believe the correct behavior is to decline
>handling requests with other methods so that later modules (eg mod_action)
>can handle the request; this is what most of the other modules that work
>on a specific mime-type do.  The symptom that manifest this problems was
>the server returning "404 Not Found" in response to an attempt to publish
>a .map file via http PUT.
>
>Attached is a tiny patch to add the proper check.
>
>Thanks for the great server.
>
>Jay Bloodworth
>
>+---------------------------------+------------------------------+
>| Jay Bloodworth                  | jay@pathways.sde.state.sc.us |
>| Network Technician              | Voice: (803) 734-7000        |
>| SC Department of Education      | Fax: (803) 734-4064          |
>+---------------------------------+------------------------------+
>
>
>*** mod_imap.c	Fri Sep 19 15:25:25 1997
>--- mod_imap.c.new	Fri Sep 19 15:25:25 1997
>***************
>*** 633,639 ****
>    char *imap_base = icr->imap_base ?
>      icr->imap_base : IMAP_BASE_DEFAULT;
>  
>!   FILE *imap = pfopen(r->pool, r->filename, "r"); 
>  
>    if ( ! imap ) 
>      return NOT_FOUND;
>--- 633,643 ----
>    char *imap_base = icr->imap_base ?
>      icr->imap_base : IMAP_BASE_DEFAULT;
>  
>!   FILE *imap; 
>! 
>!   if (r->method_number != M_GET) return DECLINED;
>! 
>!   imap = pfopen(r->pool, r->filename, "r"); 
>  
>    if ( ! imap ) 
>      return NOT_FOUND;
--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
"it's a big world, with lots of records to play." - sig   brian@organic.com

Mime
View raw message