Received: (from majordom@localhost) by hyperreal.org (8.8.5/8.8.5) id UAA10696; Sun, 24 Aug 1997 20:07:30 -0700 (PDT) Received: from twinlark.arctic.org (twinlark.arctic.org [204.62.130.91]) by hyperreal.org (8.8.5/8.8.5) with SMTP id UAA10690 for ; Sun, 24 Aug 1997 20:07:24 -0700 (PDT) Received: (qmail 9915 invoked by uid 500); 25 Aug 1997 03:03:15 -0000 Date: Sun, 24 Aug 1997 20:03:14 -0700 (PDT) From: Dean Gaudet To: new-httpd@apache.org Subject: Re: cvs commit: apachen/src/main http_core.h httpd.h In-Reply-To: <9708241905.aa28298@paris.ics.uci.edu> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org Well ... it's my fault. I changed those from "int d_is_fnmatch" to a :1 bitfield, knowing full well that the value 1 does not fit in an int :1 field ... but I didn't change the code to use -1 instead of 1. Those structure changes to bitfields are new in 1.3a2 anyhow. Dean On Sun, 24 Aug 1997, Roy T. Fielding wrote: > Eh? What warnings on Irix justify an API change? > > ....Roy > > In message <199708231617.JAA08202@hyperreal.org>, Ben Laurie writes: > >ben 97/08/23 09:17:14 > > > > Modified: src/main http_core.h httpd.h > > Log: > > Fix warnings on Irix. > > > > Revision Changes Path > > 1.27 +1 -1 apachen/src/main/http_core.h > > > > Index: http_core.h > > =================================================================== > > RCS file: /export/home/cvs/apachen/src/main/http_core.h,v > > retrieving revision 1.26 > > retrieving revision 1.27 > > diff -u -r1.26 -r1.27 > > --- http_core.h 1997/08/06 20:21:25 1.26 > > +++ http_core.h 1997/08/23 16:17:12 1.27 > > @@ -176,7 +176,7 @@ > > * directory_walk() and its relatives, this field was created and > > * is set to the result of that call. > > */ > > - int d_is_fnmatch : 1; > > + unsigned d_is_fnmatch : 1; > > > > /* System Resource Control */ > > #ifdef RLIMIT_CPU > > > > > > > > 1.143 +2 -2 apachen/src/main/httpd.h > > > > Index: httpd.h > > =================================================================== > > RCS file: /export/home/cvs/apachen/src/main/httpd.h,v > > retrieving revision 1.142 > > retrieving revision 1.143 > > diff -u -r1.142 -r1.143 > > --- httpd.h 1997/08/23 16:01:22 1.142 > > +++ httpd.h 1997/08/23 16:17:13 1.143 > > @@ -667,10 +667,10 @@ > > */ > > char *auth_type; /* Ditto. */ > > > > - int aborted : 1; /* Are we still talking? */ > > + unsigned aborted : 1; /* Are we still talking? */ > > int keepalive : 2; /* Are we using HTTP Keep-Alive? > > * -1 fatal error, 0 undecided, 1 yes */ > > - int keptalive : 1; /* Did we use HTTP Keep-Alive? */ > > + unsigned keptalive : 1; /* Did we use HTTP Keep-Alive? */ > > int double_reverse : 2; /* have we done double-reverse DNS? > > * -1 yes/failure, 0 not yet, 1 yes/success */ > > int keepalives; /* How many times have we used it? */ > > > > > > > >