Received: (from majordom@localhost) by hyperreal.org (8.8.5/8.8.5) id BAA29098; Fri, 22 Aug 1997 01:26:10 -0700 (PDT) Received: from gate-isdn.ukweb.com (gate-isdn.ukweb.com [194.152.65.149]) by hyperreal.org (8.8.5/8.8.5) with SMTP id BAA29089 for ; Fri, 22 Aug 1997 01:26:05 -0700 (PDT) Received: from aardvark.ukweb.com [192.168.2.4] by gate-isdn.ukweb.com with smtp (Exim 1.61 #1) id 0x1p2v-0007Du-00; Fri, 22 Aug 1997 09:26:17 +0100 Date: Fri, 22 Aug 1997 09:26:02 +0100 (BST) From: Paul Sutton To: new-httpd@apache.org cc: Coar@decus.org Subject: Re: Rename SetEnvIf* to RequestMatch* ? In-Reply-To: <97082113390916@decus.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org On Thu, 21 Aug 1997, Rodent of Unusual Size wrote: > Alexei requested that SetEnvIf and SetEnvIfNoCase be renamed to > {mumble}Match* to be more inline with other RE-handling directives. > The first pass suggestion was HeaderMatch*, but that got vetoed by > Paul because it's more powerful than that. I suggested > RequestMatch*, but the discussion stopped at that point. > > So.. votes for or against renaming to RequestMatch*? I'll commit > that change on Saturday unless discussion says nay (lazy voting > rules). I am against this naming scheme. The semantics of SetEnvIf are to set and environment variable *if* some condition is true. So it seems that SetEnvIf is a completely logical, correct and explanatory name. It is also consistent with the existing SetEnv which provides an unconditional environment variable setting function. Leaving the directive as SetEnvIf makes its similarity with SetEnv clear, and has the fortunate side-effect of keeping both directives close together in sorted lists of directives. Keeping the name as SetEnvIf also allows us room in the future to expand its role to (for example) set an envvar based on an already existing env var. //pcs