Received: (from majordom@localhost) by hyperreal.org (8.8.5/8.8.5) id PAA22865; Tue, 19 Aug 1997 15:27:28 -0700 (PDT) Received: from veal.organic.com (h20.n145.organic.com [204.152.145.20]) by hyperreal.org (8.8.5/8.8.5) with ESMTP id PAA22793 for ; Tue, 19 Aug 1997 15:27:18 -0700 (PDT) Received: from localhost (akosut@localhost) by veal.organic.com (8.8.3/8.6.12) with SMTP id PAA10464 for ; Tue, 19 Aug 1997 15:27:13 -0700 (PDT) X-Authentication-Warning: veal.organic.com: akosut owned process doing -bs Date: Tue, 19 Aug 1997 15:27:11 -0700 (PDT) From: Alexei Kosut To: new-httpd@apache.org Subject: Re: [PATCH] Re: SIG{TERM,KILL} and child_exit In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org On Tue, 19 Aug 1997, Dean Gaudet wrote: > This looks like a good start. > > I'd move destroy_pool into child_exit_modules, just for consistency. No; child_exit_modules() shouldn't, IMHO, do anything more than call the child_exit API handlers. None of the other http_config functions do anything but that. Adding other functionality, like destroying pools or exiting, is asking for trouble, because you might want to use call_exit_modules() for some other purpose (I have no idea what). That's why I moved (in my patch) exit() out of child_exit_modules. > accept_mutex_cleanup() and cleanup_scoreboard() absolutely must be called. > You seem to have lost them below. Erg. You're right. I forgot about that. -- Alexei Kosut