Received: (from majordom@localhost) by hyperreal.org (8.8.5/8.8.5) id QAA05066; Wed, 20 Aug 1997 16:59:00 -0700 (PDT) Received: from valis.worldgate.com (marcs@valis.worldgate.com [198.161.84.2]) by hyperreal.org (8.8.5/8.8.5) with ESMTP id QAA05038 for ; Wed, 20 Aug 1997 16:58:52 -0700 (PDT) Received: from localhost (marcs@localhost) by valis.worldgate.com (8.8.7/8.8.7) with SMTP id RAA24319 for ; Wed, 20 Aug 1997 17:58:50 -0600 (MDT) Date: Wed, 20 Aug 1997 17:58:50 -0600 (MDT) From: Marc Slemko To: TLOSAP Subject: Re: grr. bug in 1.2.3 proxy In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org So, what do we want to do? I will put up a bit note on the web site after I eat if no one beats me to it; the sooner the better, before too many download it. Do we want to do 1.2.4 right away or work something else out? On Wed, 20 Aug 1997, Marc Slemko wrote: > Grr. The 1.2.3 proxy is deadly broken, ie. it sets "GET http://host/path > HTTP/1.0" requests to origin servers instead of just "GET /path HTTP/1.0". > > Index: proxy_http.c > =================================================================== > RCS file: /export/home/cvs/apache/src/modules/proxy/proxy_http.c,v > retrieving revision 1.17.2.3 > diff -c -r1.17.2.3 proxy_http.c > *** proxy_http.c 1997/08/17 21:00:48 1.17.2.3 > --- proxy_http.c 1997/08/20 23:52:25 > *************** > *** 250,256 **** > bpushfd(f, sock, sock); > > hard_timeout ("proxy send", r); > ! bvputs(f, r->method, " ", url, " HTTP/1.0\015\012", NULL); > bvputs(f, "Host: ", desthost, NULL); > if (destportstr != NULL && destport != DEFAULT_PORT) > bvputs(f, ":", destportstr, "\015\012", NULL); > --- 250,256 ---- > bpushfd(f, sock, sock); > > hard_timeout ("proxy send", r); > ! bvputs(f, r->method, " ", urlptr, " HTTP/1.0\015\012", NULL); > bvputs(f, "Host: ", desthost, NULL); > if (destportstr != NULL && destport != DEFAULT_PORT) > bvputs(f, ":", destportstr, "\015\012", NULL); >