Received: (from majordom@localhost) by hyperreal.org (8.8.5/8.8.5) id FAA19914; Mon, 25 Aug 1997 05:14:20 -0700 (PDT) Received: from eastwood.aldigital.algroup.co.uk (eastwood.aldigital.algroup.co.uk [194.128.162.193]) by hyperreal.org (8.8.5/8.8.5) with SMTP id FAA19909 for ; Mon, 25 Aug 1997 05:14:15 -0700 (PDT) Received: from freeby.ben.algroup.co.uk (freeby.ben.algroup.co.uk [193.133.15.6]) by eastwood.aldigital.algroup.co.uk (8.6.12/8.6.12) with ESMTP id MAA18978 for ; Mon, 25 Aug 1997 12:13:59 GMT Received: from naughty (naughty.ben.algroup.co.uk [193.133.15.107]) by freeby.ben.algroup.co.uk (8.6.12/8.6.12) with ESMTP id NAA10635 for ; Mon, 25 Aug 1997 13:13:43 +0100 Message-ID: <340176E8.1627ECA0@algroup.co.uk> Date: Mon, 25 Aug 1997 13:13:28 +0100 From: Ben Laurie Organization: A.L. Digital Ltd. X-Mailer: Mozilla 4.01 [en] (WinNT; I) MIME-Version: 1.0 To: new-httpd@apache.org Subject: Re: cvs commit: apachen/src/main http_core.h httpd.h X-Priority: 3 (Normal) References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org Dean Gaudet wrote: > > Well ... it's my fault. I changed those from "int d_is_fnmatch" to a :1 > bitfield, knowing full well that the value 1 does not fit in an int :1 > field ... but I didn't change the code to use -1 instead of 1. Those > structure changes to bitfields are new in 1.3a2 anyhow. This is why the standard typedef for BOOL (int) is wrong. It should be unsigned, for the simple reason that: onebitfield=boolean; assert(onebitfield == boolean); fails, if BOOL is int! Changing the code to use -1 is _not_ the way to fix this. Cheers, Ben. -- Ben Laurie |Phone: +44 (181) 994 6435|Apache Group member Freelance Consultant |Fax: +44 (181) 994 6472|http://www.apache.org and Technical Director|Email: ben@algroup.co.uk |Apache-SSL author A.L. Digital Ltd, |http://www.algroup.co.uk/Apache-SSL London, England. |"Apache: TDG" http://www.ora.com/catalog/apache