Received: (from majordom@localhost) by hyperreal.org (8.8.5/8.8.5) id OAA02391; Fri, 22 Aug 1997 14:33:16 -0700 (PDT) Received: from brianb.organic.com (localhost.hyperreal.org [127.0.0.1]) by hyperreal.org (8.8.5/8.8.5) with SMTP id OAA02361 for ; Fri, 22 Aug 1997 14:33:05 -0700 (PDT) Message-Id: <3.0.3.32.19970822142207.0092a420@localhost> X-Sender: brian@localhost X-Mailer: QUALCOMM Windows Eudora Pro Version 3.0.3 (32) Date: Fri, 22 Aug 1997 14:22:07 -0700 To: new-httpd@apache.org From: Brian Behlendorf Subject: Re: [PATCH] from uunet: don't log anything if no TransferLog In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org +1. Simple, elegant. Brian At 10:13 AM 8/22/97 -0700, Dean Gaudet wrote: >[I received a bunch of patches from UUnet which they apply to every >release. I busted them apart into smaller pieces, but haven't tested any >of them. Consider this to be a +1 for inclusion in 1.3. I'm hoping >someone else will redo these as patches against 1.3.] > >FWIW, I had to do a similar patch for hotwired who also uses a customized >logging module. This does mean people will need to look at their config >files on update ... > >Dean > >Thu Aug 14 12:01:28 1997 David J. MacKenzie > > * mod_log_config.c: If no TransferLog is given explicitly, decline > to log. This supports coexistence with other logging modules, > such as the custom one that UUNET uses. > >Index: src/mod_log_config.c >--- mod_log_config.c 1997/07/08 21:08:31 1.1 >+++ mod_log_config.c 1997/07/08 21:22:47 1.2 >@@ -51,6 +51,9 @@ > */ > > /* >+ * Modified by djm@va.pubnix.com: >+ * If no TransferLog is given explicitly, decline to log. >+ * > * This is module implements the TransferLog directive (same as the > * common log module), and additional directives, LogFormat and CustomLog. > * >@@ -532,6 +535,10 @@ > int len = 0; > array_header *format; > >+ if (cls->fname == NULL) { >+ return DECLINED; >+ } >+ > format = cls->format ? cls->format : default_format; > > strsa= make_array(r->pool, format->nelts,sizeof(char*)); >@@ -698,6 +705,10 @@ > array_header *default_format) { > if (cls->log_fd > 0) return cls; /* virtual config shared w/main server */ > >+ if (cls->fname == NULL) { >+ return cls; /* Leave it NULL to decline. */ >+ } >+ > if (*cls->fname == '|') { > FILE *dummy; > > > > --=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-- "Why not?" - TL brian@organic.com - hyperreal.org - apache.org