httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: segfaults on CGI's with current CVS snapshot
Date Mon, 04 Aug 1997 04:59:03 GMT
Nope I doubt it's that.  this_conf is actually dead outside of the inner
loop where it's used ... and it's definately set properly by each case in
there.  The only use of this_conf is protected by an "if (this_conf) {}". 

Dean

On Sun, 3 Aug 1997, Roy T. Fielding wrote:

> >The only thing I can think of is that get_module_config() is returning
> >a null pointer and none of the _walk routines are checking for it,
> >which might happen if m->module_index is screwed in http_config.c,
> >but too much has changed in http_config.c to be able to find anything.
> 
> OTOH, it could be a side-effect of the following change, which might
> only affect some types of vhost configurations.  No idea what the
> side-effect might be, or how to fix it.  Dean?
> 
> ....Roy
> 
> Index: http_request.c
> ===================================================================
> RCS file: /export/home/cvs/apache/src/http_request.c,v
> retrieving revision 1.66
> retrieving revision 1.67
> diff -c -r1.66 -r1.67
> *** http_request.c	1997/07/20 18:52:41	1.66
> --- http_request.c	1997/08/01 08:01:21	1.67
> ***************
> *** 349,355 ****
>           core_dir_config *core_dir =
>   	  (core_dir_config *)get_module_config(per_dir_defaults, &core_module);
>   	int overrides_here;
> !         void *this_conf = NULL, *htaccess_conf = NULL;
>   	char *test_dirname_tail;
>   	int j;
>   
> --- 349,355 ----
>           core_dir_config *core_dir =
>   	  (core_dir_config *)get_module_config(per_dir_defaults, &core_module);
>   	int overrides_here;
> !         void *this_conf, *htaccess_conf = NULL;
>   	char *test_dirname_tail;
>   	int j;
>   
> ***************
> *** 380,385 ****
> --- 380,386 ----
>   	      (core_dir_config *)get_module_config(entry_config, &core_module);
>   	    entry_dir = entry_core->d;
>   	
> + 	    this_conf = NULL;
>   	    if (entry_core->r) {
>   		if (!regexec(entry_core->r, test_dirname, 0, NULL,
>   			     (j == num_sec) ? 0 : REG_NOTEOL)) {
> 


Mime
View raw message