httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexei Kosut <ako...@organic.com>
Subject Re: [PATCH] Re: SIG{TERM,KILL} and child_exit
Date Tue, 19 Aug 1997 22:27:11 GMT
On Tue, 19 Aug 1997, Dean Gaudet wrote:

> This looks like a good start.
> 
> I'd move destroy_pool into child_exit_modules, just for consistency.

No; child_exit_modules() shouldn't, IMHO, do anything more than call the
child_exit API handlers. None of the other http_config functions do
anything but that. Adding other functionality, like destroying pools or
exiting, is asking for trouble, because you might want to use
call_exit_modules() for some other purpose (I have no idea what). That's
why I moved (in my patch) exit() out of child_exit_modules.

> accept_mutex_cleanup() and cleanup_scoreboard() absolutely must be called.
> You seem to have lost them below.

Erg. You're right. I forgot about that.

-- Alexei Kosut <akosut@organic.com>


Mime
View raw message