httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marc Slemko <ma...@worldgate.com>
Subject Dean broke it (file based scoreboards)
Date Sun, 03 Aug 1997 19:04:20 GMT
----------------------------
revision 1.180
date: 1997/07/17 22:27:30;  author: dgaudet;  state: Exp;  lines: +5 -3
Added child_init method.
----------------------------

The below patch broke all systems that use file based 
scoreboards.  reopen_scoreboard() should go before the setuid(), 
although the update_child_status can go after.  Did you have some other
reason for changing this Dean?

Index: http_main.c
===================================================================
RCS file: /export/home/cvs/apache/src/http_main.c,v
retrieving revision 1.179
retrieving revision 1.180
diff -u -r1.179 -r1.180
--- http_main.c 1997/07/15 21:39:54     1.179
+++ http_main.c 1997/07/17 22:27:30     1.180
@@ -2098,9 +2098,6 @@
     child_num = child_num_arg;
     requests_this_child = 0;
 
-    reopen_scoreboard(pconf);
-    (void)update_child_status(child_num, SERVER_READY, (request_rec*)NULL);
-
 #ifdef MPE
     /* Only try to switch if we're running as MANAGER.SYS */
     if (geteuid() == 1 && user_id > 1) {
@@ -2118,6 +2115,11 @@
         GETUSERMODE();
     }
 #endif
+
+    child_init_modules(pconf, server_conf);
+
+    reopen_scoreboard(pconf);
+    (void)update_child_status(child_num, SERVER_READY, (request_rec*)NULL);
 
     /*
      * Setup the jump buffers so that we can return here after



Mime
View raw message