httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@engelschall.com (Ralf S. Engelschall)
Subject Re: commit logs are broken
Date Fri, 08 Aug 1997 10:09:08 GMT

In article <Pine.LNX.3.95dg3.970808005644.5790A-100000@twinlark.arctic.org> you wrote:
> syntax error in file /export/home/cvs/CVSROOT/log_accum.pl at line 356,
> next 2 tokens "/^[ \t]+Tag:/ and"
> Execution of /export/home/cvs/CVSROOT/log_accum.pl aborted due to
> compilation errors.

> I think in the future it'd be nice if these changes at least pass "perl
> -c" :) 

Haha, good joke, Dean ;-)

| taz: {9} % perl -v
| This is perl, version 5.004_01
| [...]
| taz: {10} % perl -c /export/home/cvs/CVSROOT/log_accum.pl
| log_accum.pl syntax OK
| taz: {11} % /usr/local/bin/perl5 -v
| 
| This is perl, version 5.003 with EMBED
| [...]
| taz: {12} % /usr/local/bin/perl5 -c /export/home/cvs/CVSROOT/log_accum.pl
| log_accum.pl syntax OK
| taz: {13} %

It passed "perl -c" really, as you can see. But I use perl5.004 which knows
the "and" operator and on taz the standard perl which CVS finds is a 5.003 and
this one does not have the low-priority "and". It only has the high-priority
"&&" operator.  But it is as braindead is is can and says "syntax OK" even it
is not ok.

Shit happens, so we have to downgrade to 5.003 syntax:

--- log_accum.pl.old    Fri Aug  8 03:05:35 1997
+++ log_accum.pl        Fri Aug  8 03:06:31 1997
@@ -353,7 +353,7 @@
         push (@branch_lines, split);
         next;
     }
-    next if (/^[ \t]+Tag:/ and $state != $STATE_LOG);
+    next if (m/^[ \t]+Tag:/ && ($state != $STATE_LOG));
     if (/^Modified Files/) { $state = $STATE_CHANGED; next; }
     if (/^Added Files/)    { $state = $STATE_ADDED;   next; }
     if (/^Removed Files/)  { $state = $STATE_REMOVED; next; }

Brian, again: Please commit this little patch.

Hmmmm....
                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com

Mime
View raw message