Received: (from majordom@localhost)
	by hyperreal.org (8.8.5/8.8.5) id MAA28485;
	Sun, 27 Jul 1997 12:05:15 -0700 (PDT)
Received: from twinlark.arctic.org (twinlark.arctic.org [204.62.130.91])
	by hyperreal.org (8.8.5/8.8.5) with SMTP id MAA28478
	for <new-httpd@apache.org>; Sun, 27 Jul 1997 12:05:13 -0700 (PDT)
Received: (qmail 21427 invoked by uid 500); 27 Jul 1997 19:05:12 -0000
Date: Sun, 27 Jul 1997 12:05:11 -0700 (PDT)
From: Dean Gaudet <dgaudet@arctic.org>
To: new-httpd@apache.org
Subject: Re: [PATCH] loglevels final?
In-Reply-To: <199707271820.NAA12019@sierra.zyzzyva.com>
Message-ID: <Pine.LNX.3.95dg3.970727115858.16222d-100000@twinlark.arctic.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@apache.org

While I'm much happier with this approach (I too want it to be simple, and
syslog-style levels are just fine with me) you didn't address one of my
earlier complaints. 

On Sun, 27 Jul 1997, Randy Terbush wrote:

> -void log_pid(pool *p, char *pid_fname) {
> +API_EXPORT(void) aplog_error (int level, const request_rec *r, const char *routine,
> +			      const char *file, const char *fmt, ...)
> +{

I think that the prototype should be: 

API_EXPORT(void) aplog_error (int level, const request_rec *r,
    const char *fmt, ...);

one of the reasons is this code: 

> +    if (timestamp) { /* timestamp means we are logging to file */
> +	fprintf(r->server->error_log, "%s", errstr);
> +	vfprintf(r->server->error_log, fmt, args);
> +	fflush(r->server->error_log);
> +    }
> +    else {
> +	if (errstr)
> +	    syslog(level, "%s", errstr);
> +
> +	vsyslog(level, fmt, args);
> +    }

Is not atomic for the syslog. 

I also feel that "routine" and "file" are very vague, and don't apply to
all situations.

BTW you should probably also implement:

API_EXPORT(void) aplog_verror (int level, const request_rec *r,
    va_list args); 

Dean