httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marc Slemko <ma...@worldgate.com>
Subject Re: [PATCH] Enable sortable columns in FancyIndexed directories
Date Wed, 23 Jul 1997 14:53:24 GMT
Haven't done anything other than a quick read of the code yet...

On Wed, 23 Jul 1997, Rodent of Unusual Size wrote:

> Index: mod_autoindex.c
> ===================================================================
> RCS file: /export/home/cvs/apache/src/mod_autoindex.c,v
> retrieving revision 1.40
> diff -c -u -r1.40 mod_autoindex.c
> /usr/bin/diff: conflicting specifications of output style

While a conflict and unidiff at the same time would be... erm...
interesting, diff don't do that.  <g>

> +    if (keyid == K_SIZE) {
> +	p->size_cmp = pcalloc (r->pool, 14);
> +	ap_snprintf (p->size_cmp, 14, "%013d", p->size);
> +    }
> +    if (keyid == K_LAST_MOD) {
> +	struct tm *ts = localtime(&p->lm);
> +
> +	p->lm_cmp = pcalloc (r->pool, 15);
> +	strftime (p->lm_cmp, 14, "%Y%m%d%H%M%S", ts);

Why 15 for pcalloc and 14 for strftime?

Why use pcalloc instead of palloc?


Mime
View raw message