httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marc Slemko <ma...@worldgate.com>
Subject Re: Please apply this patch to make reconfiguration easy (fwd)
Date Mon, 14 Jul 1997 22:27:25 GMT
That would make me happier too.

On Mon, 14 Jul 1997, Alexei Kosut wrote:

> On Mon, 14 Jul 1997, Marc Slemko wrote:
> 
> > There you go.  A "vendor" (FreeBSD ports maintainer) asking for a crapload
> > of ifdefs wrapped around things.  Since we always listen to vendors,
> > perhaps this can sneak in.  <g>
> > 
> > A +1 from me.  It isn't necessary since these things can all be overridden
> > from the conf file, but it makes things nicer.  This has been discussed
> > enough times that perhaps now people will quietly agree.
> 
> +1. Looks harmless enough. But I'd like the #ifdefs after the comments, not
> before them. For example, change this:
> 
> > + #ifndef RESOURCE_CONFIG_FILE
> >   /* The name of the document config file */
> >   #define RESOURCE_CONFIG_FILE "conf/srm.conf"
> > + #endif
> 
> to this:
> 
> >   /* The name of the document config file */
> > + #ifndef RESOURCE_CONFIG_FILE
> >   #define RESOURCE_CONFIG_FILE "conf/srm.conf"
> > + #endif
> 
> That would make me happier.
> 
> -- Alexei Kosut <akosut@organic.com>
> 


Mime
View raw message