httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] http_main big patch
Date Mon, 30 Jun 1997 00:04:10 GMT
On Sun, 29 Jun 1997, Marc Slemko wrote:

> Is it wise to remove the (currently) unused child status functions like
> count_busy_servers()?  While they aren't used right now, other modules may
> have a use for them.

None of the shipped modules use them ... and they shouldn't really have
been globals in the first place.  NT also makes some of those removed
functions bogus.

> Isn't there another sleep(1) or two that should be replaced by a select()?
> Should we add the option of using poll()?  Probably not worth it since we
> already have to use select() for other things.

There are other sleeps ... there's the sleep(10) we use to slow down when
we've had a fork fail.  There's the sleep(3) that children use during
cleanup in alloc.c.  But these didn't seem important to fix this way, I
could be wrong.  I remember it was someone from freebsd-land suggesting
we switch from sleep to select(), for a signalling reason that I've
forgotten.

> 
> I am confused about set_max_daemons_limit.
> 
> +static void set_max_daemons_limit (void)
>  {
> +    if (daemons_limit > max_daemons_limit) {
> +       max_daemons_limit = daemons_limit;
> +    }
> 
> So you are just setting this based on MaxServers?  Why not keep a record
> of the highest slot we have actually used?

Good change, I'll do it.

Dean


Mime
View raw message