httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] fix to assert bugosity
Date Sun, 29 Jun 1997 19:18:52 GMT
Guess I jumped the gun on this.  I just committed a change to ap_assert().

Dean

On Sun, 29 Jun 1997, Marc Slemko wrote:

> On Sun, 29 Jun 1997, Rodent of Unusual Size wrote:
> 
> > >From the fingers of Marc Slemko flowed the following:
> > >
> > >I would prefer an ap_assert instead on the basis that it is best to avoid
> > >messing with system defines if you don't have to, but that's just me...
> > 
> >     That's fine with me; I prefer that, too.  I know nothing about
> >     assert() - I was just trying to clean up the compilation warnings in
> >     the most painless way.
> 
> Ok, now that we have magically gained an assert() macro of our own that is
> more useful for us, do we want to trash the inclusion of assert.h anywhere
> that httpd.h is included?  The other option would be to change our assert
> to ap_assert and change all the asserts we feel like to ap_assert.
> 
> Unless anyone comes up with any better suggestions, one of the two should
> be done.
> 
> One thing we have to be careful of is that log_assert() can't possible
> call any code which does an assert() itself. 
> 
> > 
> > >Hmm.  Why do we have to include assert.h to begin with?
> > >
> > >Oh, something else I noticed about this change... unless I am missing
> > >something, it is BOGUS.  Bad.  Bad.
> > 
> >     I assume you mean Ben's original change.. <g>
> 
> Yes.
> 
> 


Mime
View raw message