httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] create fd slack
Date Sun, 22 Jun 1997 04:05:18 GMT
On Sat, 21 Jun 1997, Marc Slemko wrote:
> > popenf() always pushes things above the high slack line.  pfopen()
> > in append mode (which we happen to conveniently parse and handle with
> > an open/fdopne) pushes things above the low slack line.  make_sock()
> > pushes sockets above the high slack line.
> 
> Are you convinced it is appropriate to only push some pfopens() higher?
> While it is true that it is no problem right now... it isn't as clean as
> it could be.

For a cleaner solution I want the caller of pfopen/popenf to be able
to control it as well, which is definately a 1.3 thing.  Only problem
with doing it for pfopen is that it requires us to interpret the mode
string ... although I suppose I could do an fopen, and then ap_slack
(fileno(fp)) and then fdopen that.  Yuck, but it works.

It just so happens that the error_log uses "a" and that was the easiest case
to slack :)

> How about adding a define to disable it completely?  I want to
> be able to tell someone who is having problems to "add -DNO_PROZAC to
> EXTRA_CFLAGS and recompile".

Sure.

> If you are referring to them using unsigned char for _file in the
> FILE structure, I wouldn't call it a C library bug, just a patheticly
> silly limitation.  You should add to the comment clarifying exactly
> what you mean.

Yup.

Dean


Mime
View raw message