httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marc Slemko <ma...@worldgate.com>
Subject Re: [PATCH] SendBufferSize not valid in virtualhost
Date Tue, 10 Jun 1997 00:05:51 GMT
On Mon, 9 Jun 1997, Randy Terbush wrote:

> 
> I would request a vote to include this in the 1_2_X branch. This fixes
> a bug IMO and we might as well have it applied to the tree for the 
> time when we release 1.2.1 (which we will).

I am not sure it has yet been finalized that any releases except for
urgent bug-fixes should be released in the 1.2 tree.  If the plan is for
1.3 to be a quickish release that supports NT + fixes bugs, it is
counterproductive to try to backport all the little changes to 1.2.  I
would suggest waiting a week or so until we have a better agreement and
idea of how we will proceed from here.  At that point, it will be easy to
merge any changes that have been commited in the meantime if desired.

> 
> 
> > 
> > > > Proposed for both branches of the tree.
> > 
> > I will amend this to be proposed for HEAD only for now.  I don't see it
> > being worthwhile holding back things like this until we decide what is
> > going on.  If we decide to leave 1.2 as is, then no problem later and if
> > we decide to bring back changes to 1.2 then we just have to merge it
> > later.
> > 
> > > > 
> > > > Index: src/http_core.c
> > > > ===================================================================
> > > > RCS file: /export/home/cvs/apache/src/http_core.c,v
> > > > retrieving revision 1.81
> > > > diff -c -r1.81 http_core.c
> > > > *** http_core.c	1997/05/08 13:09:24	1.81
> > > > --- http_core.c	1997/06/08 00:11:01
> > > > ***************
> > > > *** 867,872 ****
> > > > --- 867,875 ----
> > > >   
> > > >   const char *set_send_buffer_size (cmd_parms *cmd, void *dummy, char
*arg) {
> > > >       int s = atoi (arg);
> > > > +     if (cmd->server->is_virtual) {
> > > > +         return "SendBufferSize directive can not be used in <VirtualHost>";
> > > > +     }
> > > >       if (s < 512 && s != 0) {
> > > >           return "SendBufferSize must be >= 512 bytes, or 0 for system
default.";
> > > >       }
> > > > Index: htdocs/manual/mod/core.html
> > > > ===================================================================
> > > > RCS file: /export/home/cvs/apache/htdocs/manual/mod/core.html,v
> > > > retrieving revision 1.56
> > > > diff -c -r1.56 core.html
> > > > *** core.html	1997/06/04 16:14:13	1.56
> > > > --- core.html	1997/06/08 00:11:05
> > > > ***************
> > > > *** 1158,1164 ****
> > > >   <A name="sendbuffersize"><h2>SendBufferSize directive</h2></A>
> > > >   <!--%plaintext &lt;?INDEX {\tt SendBufferSize} directive&gt;
-->
> > > >   <strong>Syntax:</strong> SendBufferSize <em>bytes</em><br>
> > > > ! <strong>Context:</strong> server config, virtual host<br>
> > > >   <strong>Status:</strong> core<p>
> > > >   
> > > >   The server will set the TCP buffer size to the number of bytes
> > > > --- 1158,1164 ----
> > > >   <A name="sendbuffersize"><h2>SendBufferSize directive</h2></A>
> > > >   <!--%plaintext &lt;?INDEX {\tt SendBufferSize} directive&gt;
-->
> > > >   <strong>Syntax:</strong> SendBufferSize <em>bytes</em><br>
> > > > ! <strong>Context:</strong> server config<br>
> > > >   <strong>Status:</strong> core<p>
> > > >   
> > > >   The server will set the TCP buffer size to the number of bytes
> > > 
> > > 
> > > 
> 
> 
> 


Mime
View raw message