httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@gonzo.ben.algroup.co.uk>
Subject Re: [PATCH] fix to assert bugosity
Date Sun, 29 Jun 1997 20:11:25 GMT
Marc Slemko wrote:
> 
> On Sun, 29 Jun 1997, Rodent of Unusual Size wrote:
> 
> > >From the fingers of Marc Slemko flowed the following:
> > >
> > >I would prefer an ap_assert instead on the basis that it is best to avoid
> > >messing with system defines if you don't have to, but that's just me...
> > 
> >     That's fine with me; I prefer that, too.  I know nothing about
> >     assert() - I was just trying to clean up the compilation warnings in
> >     the most painless way.
> 
> Ok, now that we have magically gained an assert() macro of our own that is
> more useful for us, do we want to trash the inclusion of assert.h anywhere
> that httpd.h is included?  The other option would be to change our assert
> to ap_assert and change all the asserts we feel like to ap_assert.

I vote for nuking assert.h everywhere...

I was contemplating adding an asserts(server,fact) macro, too, for
completeness.

> 
> Unless anyone comes up with any better suggestions, one of the two should
> be done.
> 
> One thing we have to be careful of is that log_assert() can't possible
> call any code which does an assert() itself. 

We could add a reentrancy flag to avoid that.

Cheers,

Ben.

-- 
Ben Laurie                Phone: +44 (181) 994 6435  Email: ben@algroup.co.uk
Freelance Consultant and  Fax:   +44 (181) 994 6472
Technical Director        URL: http://www.algroup.co.uk/Apache-SSL
A.L. Digital Ltd,         Apache Group member (http://www.apache.org)
London, England.          Apache-SSL author

Mime
View raw message