httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: [PATCH] NT cleanup
Date Mon, 16 Jun 1997 16:04:46 GMT
Ben Laurie wrote:
> 
> Jim Jagielski wrote:
> > Oh yeah... nt/multithread.c does the right thing with respect
> > to these functions.
> 
> Yeah, the snag is that using those cause an unnecessary call/return, with
> associated performance penalty - which has been condemned in the past.

Hmmm... But most good optimizing compilers should take care of that,
shouldn't they?

> 
> > 
> > These are the same concerns I had, but I think the delay is
> > starting to have some major factors.. We can keep the
> > fucntions called by spawn_child(_err) just the way they are but
> > simply remove the exit(1) in the "UNIX" section of these
> > and let spawn_child do the exit for us. If these functions
> > return then we know the exec failed :)
> 
> I think I prefer that - note that the massive duplication of these functions
> is a good candidate for abstraction (as I mention in README.NT).
> 
> Cheers,
> 
> Ben.
> 
> -- 
> Ben Laurie                Phone: +44 (181) 994 6435  Email: ben@algroup.co.uk
> Freelance Consultant and  Fax:   +44 (181) 994 6472
> Technical Director        URL: http://www.algroup.co.uk/Apache-SSL
> A.L. Digital Ltd,         Apache Group member (http://www.apache.org)
> London, England.          Apache-SSL author
> 


-- 
====================================================================
      Jim Jagielski            |       jaguNET Access Services
     jim@jaguNET.com           |       http://www.jaguNET.com/
            "Look at me! I'm wearing a cardboard belt!"

Mime
View raw message