Received: (from majordom@localhost)
	by hyperreal.com (8.8.5/8.8.5) id TAA18824;
	Thu, 8 May 1997 19:38:18 -0700 (PDT)
Received: from sierra.zyzzyva.com (ppp01-58.zyzzyva.com [208.214.58.10])
	by hyperreal.com (8.8.5/8.8.5) with ESMTP id TAA18815
	for <new-httpd@apache.org>; Thu, 8 May 1997 19:38:14 -0700 (PDT)
Received: from sierra (localhost [127.0.0.1]) by sierra.zyzzyva.com
 (8.8.5/8.8.2) with ESMTP id VAA03631 for <new-httpd@apache.org>;
 Thu, 8 May 1997 21:36:07 -0500 (CDT)
Message-Id: <199705090236.VAA03631@sierra.zyzzyva.com>
X-Mailer: exmh version 2.0gamma 1/27/96
To: new-httpd@apache.org
Subject: Re: [PATCH] SEGV in unescape_url() 
In-reply-to: fielding's message of Thu, 08 May 1997 02:01:40 -0700.
         <9705080205.aa21765@paris.ics.uci.edu>
X-uri: http://www.zyzzyva.com/
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Thu, 08 May 1997 21:36:07 -0500
From: Randy Terbush <randy@zyzzyva.com>
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@apache.org

> >This should probably not SEGV if passed a NULL argument. The change 
> >is just a one liner. The rest is just formating changes.
> 
> It doesn't make any sense to call unescape_url() with a NULL argument.
> None of our existing code does, so I don't see where you would get a SEGV.
> 
> ....Roy

I agree that calling it with a NULL argument does not make much 
sense. This is a function that will/is commonly used by module 
developers. Just seems like a simple change to avoid potential 
frustrations.