httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] Complete fix for mod_example memory bloat
Date Sat, 03 May 1997 10:17:43 GMT
On Fri, 2 May 1997, Rodent of Unusual Size wrote:
>     One thing that's different is that I'm storing the per-request stuff
>     in the r->request_config list, which appears to be only minimally
>     supported.  I haven't found anything in the archives (yet) that
>     indicates this is discouraged or deprecated.

request_config has no defined API for promoting a request_config entry
from a subrequest to the main request.  Therefore is broken by
mod_negotiation.  I noted that when I submitted the last of the "promote
everything" patches.

For 2.0 it should either go away, or have a defined mechanism for
promotion. 

Oh yeah I forget if you note it, or if it's noted in the docs, but all
per_dir_configs should be considered "const" unless being modified by
the per_dir_merger or a configuration command handler (and only when
invoked by the core).  The reason for this is that per_dir_configs are
shared rather than copied when at all possible (and there's more possible
optimizations if this rule is kept).

Dean


Mime
View raw message