httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@gonzo.ben.algroup.co.uk>
Subject Re: [PATCH] SEGV in unescape_url()
Date Fri, 09 May 1997 06:39:41 GMT
Randy Terbush wrote:
> 
> > >This should probably not SEGV if passed a NULL argument. The change 
> > >is just a one liner. The rest is just formating changes.
> > 
> > It doesn't make any sense to call unescape_url() with a NULL argument.
> > None of our existing code does, so I don't see where you would get a SEGV.
> > 
> > ....Roy
> 
> I agree that calling it with a NULL argument does not make much 
> sense. This is a function that will/is commonly used by module 
> developers. Just seems like a simple change to avoid potential 
> frustrations.

If it is passed a NULL then some code is broken. IMO it is a Bad Thing to hide
broken code. Better to assert that the argument is not NULL. At least then you
get a clear diagnostic.

Cheers,

Ben.

-- 
Ben Laurie                Phone: +44 (181) 994 6435  Email: ben@algroup.co.uk
Freelance Consultant and  Fax:   +44 (181) 994 6472
Technical Director        URL: http://www.algroup.co.uk/Apache-SSL
A.L. Digital Ltd,         Apache Group member (http://www.apache.org)
London, England.          Apache-SSL author

Mime
View raw message