httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chuck Murcko <ch...@topsail.org>
Subject Re: Changed information for PR mod_proxy/614
Date Fri, 30 May 1997 20:31:20 GMT
Marc Slemko wrote:
> 
> On Fri, 30 May 1997, Jozsef Hollosi wrote:
> 
> > Dear Chuck:
> >
> > You properly caught the small, but real memory leak in the patch I sent in,
> > however, the just-released 1.2b11 has the leaked version of the path.
> > Although it is a minor issue, because the whole leak is at most
> > (2 * sizeof(char*))*MaxRequestsPerChild, which is just a few hundred bytes
> > in most typical configurations, but you might still want to fix it for
> > aesthetics.
> >
> > Here is a suggested fix to the fix:
> >
> > % diff proxy_util.c proxy_util.c.orig
> > 704d703
> > <     static char* charpbuf[2];
> > 724c723
> > <           hpbuf.h_addr_list = charpbuf;
> > ---
> > >           hpbuf.h_addr_list = malloc(2 * sizeof(char*));
> >
> 
> Is there a reason that proxy_util is using malloc instead of palloc?

Yes. Managing just a few bytes didn't seem to call for the overkill of
using palloc.
-- 
chuck
Chuck Murcko
The Topsail Group, West Chester PA USA
chuck@topsail.org

Mime
View raw message