httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nathan J Kurz <n...@tripod.tripod.com>
Subject Re: [PATCH] PR#506: no DefaultType means no Content-Type
Date Sun, 04 May 1997 22:18:04 GMT
> Ya know, after looking at all the code that references content_type there
> is some that should do
> 
>     r->content_type ? r->content_type : default_type(r);
> 
> In fact it seems to me that we should just set
> r->content_type = default_type(r) way early on in the request processing.
> 
> Look at mod_include and mod_dir for example, they're broken on files that
> get their Content-Type set by DefaultType.

Yes, this might be a good thing long term.  On the other hand, it
would change behaviour.  Currently you can distinguish between files
explicitly typed to the default type and and files that are defaulted.
If patched, you couldn't tell them apart.  I don't think that mod_dir
is broken because it uses different icons for "file.html" and
"file.foo" (assuming DefaultType text/html and .foo not defined).

nate@tripod.com
http://www.tripod.com


Mime
View raw message