Received: (from majordom@localhost) by hyperreal.com (8.8.4/8.8.4) id RAA15762; Thu, 24 Apr 1997 17:58:27 -0700 (PDT) Received: from twinlark.arctic.org (twinlark.arctic.org [204.62.130.91]) by hyperreal.com (8.8.4/8.8.4) with SMTP id RAA15757 for ; Thu, 24 Apr 1997 17:58:24 -0700 (PDT) Received: (qmail 27650 invoked by uid 500); 25 Apr 1997 00:58:23 -0000 Date: Thu, 24 Apr 1997 17:58:23 -0700 (PDT) From: Dean Gaudet To: new-httpd@apache.org Subject: Re: minor -Wall warning In-Reply-To: <199704250032.UAA15111@devsys.jaguNET.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org On Thu, 24 Apr 1997, Jim Jagielski wrote: > With latest CVS snapshot: > > gcc -c -O2 -DAUX -D_POSIX_SOURCE -DSTATUS -Wall util_script.c > util_script.c: In function `call_exec': > util_script.c:439: warning: `grpname' might be used uninitialized in > this function > > A little change to 'char *grpname = NULL;' will fix that. I think it's worse than that. See enclosed patch. Dean Index: util_script.c =================================================================== RCS file: /export/home/cvs/apache/src/util_script.c,v retrieving revision 1.49 diff -c -3 -r1.49 util_script.c *** util_script.c 1997/04/24 23:25:09 1.49 --- util_script.c 1997/04/25 00:57:51 *************** *** 572,579 **** log_unixerr("getgrgid", NULL, "invalid groupid", r->server); return; } - execuser = (char *) palloc (r->pool, sizeof(pw->pw_name)); execuser = pw->pw_name; } if (shellcmd) --- 572,579 ---- log_unixerr("getgrgid", NULL, "invalid groupid", r->server); return; } execuser = pw->pw_name; + grpname = gr->gr_name; } if (shellcmd)