Date: Sat, 26 Apr 1997 16:46:33 +0100 (BST)
From: Paul Sutton <paul@ukweb.com>
To: new-httpd@apache.org
Subject: Re: [PATCH] Handle write errors when no SIGPIPE
In-Reply-To: <9704252107.aa19838@paris.ics.uci.edu>
Message-ID: <Pine.LNX.3.95.970426163721.30681H-100000@aardvark.ukweb.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@apache.org

On Fri, 25 Apr 1997, Roy T. Fielding wrote:
> Nathan's comments caused me to revisit the code that I had stared at
> for so long looking for an EPIPE.  I don't know why I missed it the first
> time, but the below patch will fix this problem.  Note that it is needed
> for all systems, since our current code will silently toss data if an
> interim write fails for any reason (very bad).  It will also be a huge
> load reducer for sites sending large messages to impatient users.

I've not studied the buff.c stuff in too much detail, but doesn't bwrite
already loop if it gets an EINTR on a write()? If so, the caller here
doesn't need to check it again. And can't bwrite() itself loop on
EAGAIN's?

If bwrite() doesn't and can't do both of these, do we need a similar loop
around the bwrite() in rprintf() and rvputs() in http_protocol.c?  (and
http_bprintf.c, which has several bwrite's with unchecked return status).

//pcs