Date: Sat, 26 Apr 1997 16:15:58 +0100 (BST)
From: Paul Sutton <paul@ukweb.com>
To: new-httpd@apache.org
Subject: Re: [PATCH] properly clean up linux compilation troubles
In-Reply-To: <Pine.LNX.3.95dg3.970426012256.30990K-100000@twinlark.arctic.org>
Message-ID: <Pine.LNX.3.95.970426160218.30681G-100000@aardvark.ukweb.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@apache.org

On Sat, 26 Apr 1997, Dean Gaudet wrote:
> This reverts my LINUX_TWEAK patch, which I am regretting submitting.  It
> detects linux 1.x and 2.x systems.  For 1.x systems it leaves their conf.h
> defines the same as 1.2b7 and earlier.  For 2.x systems it defines the
> HAVE_SHMGET, and HAVE_SYS_RESOURCE_H.  In both cases it leaves
> USE_FCNTL_SERIALIZED_ACCEPT defined since I don't want to introduce the
> multiple Listen bug into Linux.

I agree in principle with this patch (and particularly getting rid of
LINUX_TWEAK). However didn't PR#336 have the problem that SHMGET did not
exists on Alpha hardware, although they were using a v2 kernel? Perhaps
the check in the Configure script should be for

  i?86-*-linux2

instead?

Also if 1.2 might be out there for a long time, isn't it possible there'll
be a Linux 3 in the future? To make it a bit more future-proof, why not
check for Linux:[2-9].* instead of just Linux:2.*

Incidently, I don't seem to have any problems with SHMGET on my Linux
1.2.13 system (from a RedHat distribution). If many or most 1.2 and higher
users are ok with shared memory, but Apache defaults to a file, many
people will get less than optimum performance. Isn't there any other more
portable way to check if a _particular_ system has shared memory (e.g.
look for an include file, try and compile a program with shmget() in it
and see if it fails)? I think autoconf would be very useful here. 

Also one little typo:

Configure:
> !     *-linux2)
>   	DEF_WANTHSREGEX=yes
>   	OS='Linux'
> ! 	CFLAGS="$CFLAGS -DLINUX=2"
> ! 	;;
> !     *-linux1)
> ! 	DEF_WANTHSREGEX=yes
> ! 	OS='Linux'
> ! 	CFLAGS="$CFLAGS -DLINUX=1"

GuessOS:
> !     Linux:2.*)
> ! 	echo "${MACHINE}-whatever-linux2"; exit 0
> ! 	;;
> ! 
> !     Linux:1.*)
>   	echo "${MACHINE}-whatever-linux"; exit 0
>   	;;
                                  ^^^^^^
                                  linux1

//pcs