Received: (from majordom@localhost) by hyperreal.com (8.8.4/8.8.4) id CAA18200; Mon, 7 Apr 1997 02:51:44 -0700 (PDT) Received: from paris.ics.uci.edu (mmdf@paris.ics.uci.edu [128.195.1.50]) by hyperreal.com (8.8.4/8.8.4) with SMTP id CAA18122 for ; Mon, 7 Apr 1997 02:51:37 -0700 (PDT) Received: from kiwi.ics.uci.edu by paris.ics.uci.edu id aa23525; 7 Apr 97 2:51 PDT To: new-httpd@apache.org Subject: Re: [PATCH] Last lingering cleanup, setsockopt error messages In-reply-to: Your message of "Sun, 06 Apr 1997 23:12:12 PDT." Date: Mon, 07 Apr 1997 02:51:00 -0700 From: "Roy T. Fielding" Message-ID: <9704070251.aa23525@paris.ics.uci.edu> Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org >On Sun, 6 Apr 1997, Marc Slemko wrote: >> Also, are you _sure_ that the extra call to sock_disable_nagle >> isn't necessary? I can certainly imagine some OSes resetting it when >> an accept() is done or only allowing it to be set after there is >> a connection... > >accept() doesn't clone TCP_* settings on some unixes. Sun used >to mention this on one of the perf pages... but the best I can find >right now is . >So -1 to the patch unless TCP_NODELAY is set after the accept. I fixed it, along with the change to the comments, before committing. .....Roy