httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason A. Dour" <...@bcc.louisville.edu>
Subject Re: [PATCH] suexec doesn't close log file
Date Mon, 07 Apr 1997 12:45:10 GMT
-----BEGIN PGP SIGNED MESSAGE-----

+1 as well.  Duh...sometimes we're amazing, Randy.  ;)

On Sun, 6 Apr 1997, Randy Terbush wrote:
> 
> +1 
> 
> > ...which means the CGI can mess with the suexec log file. 
> > 
> > Index: suexec.c
> > ===================================================================
> > RCS file: /export/home/cvs/apache/support/suexec.c,v
> > retrieving revision 1.19
> > diff -c -r1.19 suexec.c
> > *** suexec.c	1997/03/03 19:33:53	1.19
> > --- suexec.c	1997/04/06 20:01:59
> > ***************
> > *** 451,456 ****
> > --- 451,464 ----
> >       }
> >   
> >       clean_env();
> > + 
> > +     /* 
> > +      * Be sure to close the log file so the CGI can't
> > +      * mess with it.  If the exec fails, it will be reopened 
> > +      * automatically when log_err is called.
> > +      */
> > +     fclose(log);
> > +     log = NULL;
> >       
> >       /*
> >        * Execute the command, replacing our image with its own.
> 
> 
> 

# Jason A. Dour <jad@bcc.louisville.edu>                            1101
# Programmer Analyst II; Department of Radiation Oncology; Univ. of Lou.
# Finger for URLs, PGP public key, geek code, PJ Harvey info, et cetera.

-----BEGIN PGP SIGNATURE-----
Version: 2.6.2

iQCVAwUBM0jsWZo1JaC71RLxAQGyXQP/ZmMklfQTJKHw6qMGrWMQOPgITgrcz9oh
KHLwjxINCdLpiEB+M8aT0RevPl7GgkN4QdmDMT7NFc2UuxFOCiEzG0G49OBR2t7N
8FF0jvbqpFbcRJkifFjCtVPNhGL9eikVWl5yK3b+H8KsLvnL+1JCCRX7cD/h1BjE
SxhiHU0yfCs=
=uCw2
-----END PGP SIGNATURE-----


Mime
View raw message