httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@gonzo.ben.algroup.co.uk>
Subject Re: [PATCH] PR#344: 64-bit cleanups
Date Sun, 20 Apr 1997 12:56:31 GMT
Paul Sutton wrote:
> 
> On Sat, 19 Apr 1997, Dean Gaudet wrote:
> > The patch supplied in PR#344 looks good.  I've included it here.  It
> > cleans up various pointer/int 64-bit issues.   +1
> 
> Um, I guess this is ok, but I'm slightly worried about the
> 
>   close((long)fdv) 
> 
> construct. Could this cause a problem if there are any braindead systems
> which don't use ANSI prototypes (i.e. if they prototype close as "int
> close()", Apache'll try and pass a long leading to bad things, I think). 
> 
> Also can we guarantee it is safe to stick ints and longs into (void*)'s? 
> Are there any 32-bit systems which define long to be 64 bits now, but
> using 32-bit (void*)'s? 
> 
> If these things are taken care of in the C language specification, then
> ok. But if not, I'd prefer not to risk breaking any existing systems
> Apache currently works on (even obscure ones), at least until 1.2 is out
> of here. 

The proper way to deal with this stuff is to stop casting and start using
unions. Not for 1.2, though.

Cheers,

Ben.

-- 
** Buy "Apache: The Definitive Guide" from http://www.links.org/apache **
Ben Laurie                Phone: +44 (181) 994 6435  Email: ben@algroup.co.uk
Freelance Consultant and  Fax:   +44 (181) 994 6472
Technical Director        URL: http://www.algroup.co.uk/Apache-SSL
A.L. Digital Ltd,         Apache Group member (http://www.apache.org)
London, England.          Apache-SSL author

Mime
View raw message