Got this today. Seems like a very sensible idea. Perhaps even classing as a
bugfix. Can I commit it?
Cheers,
Ben.
Mitchell Blank Jr wrote:
> Hiya. Short patch to rotatelogs.c as distributed w/ apache 1.2b8. I hope
> you consider implementing this in future versions.
>
> On line 69:
>
> sprintf(buf2,"%s.%d",szLogRoot,(int)tLogStart);
>
> I changed it to:
>
> sprintf(buf2,"%s.%010d",szLogRoot,(int)tLogStart);
>
> This means that alphabetic sorts on the directory ('ls -1 /var/weblog/access/')
> will continue to match cronological order of creation after time(10**10)
> (which falls on August 8, 2001.... a year 2001 problem?)
>
> Anyway, I think that this change is a Good Thing, I hope you agree.
>
> --
> -Mitchell Blank Jr
> mitch@execpc.com
> Exec-PC, Systems Administration
--
Ben Laurie Phone: +44 (181) 994 6435 Email: ben@algroup.co.uk
Freelance Consultant and Fax: +44 (181) 994 6472
Technical Director URL: http://www.algroup.co.uk/Apache-SSL
A.L. Digital Ltd, Apache Group member (http://www.apache.org)
London, England. Apache-SSL author
|