httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: [PATCH] CutRule causes bogus entries if Rule is commented-out
Date Tue, 15 Apr 1997 12:24:23 GMT
Roy T. Fielding wrote:
> 
> This was reported to me by a fellow grad student here, who tried
> to change a rule in Configuration by first copying the rule line
> and commenting-out the original.  CutRule would grab both the new
> Rule line and the commented-out line, resulting in a bogus Makefile.
> The following patch will fix the problem.
> 
> .....Roy
> 
> Index: CutRule
> ===================================================================
> RCS file: /export/home/cvs/apache/src/helpers/CutRule,v
> retrieving revision 1.2
> diff -c -r1.2 CutRule
> *** CutRule	1996/12/04 01:48:15	1.2
> --- CutRule	1997/04/15 07:46:44
> ***************
> *** 2,6 ****
>   # note that there is a tab and a space in the character groups.
>   # Map to lowercase to make tests easier
>   
> ! egrep "Rule[	 ]+$1[	 ]*=" $2 | awk 'BEGIN {FS="="}{print $2}' | \
>   sed 's/[	 ]//g' | tr "A-Z" "a-z"
> --- 2,7 ----
>   # note that there is a tab and a space in the character groups.
>   # Map to lowercase to make tests easier
>   
> ! egrep "^[	 ]*Rule[	 ]+$1[	 ]*=" $2 | \
> ! awk 'BEGIN {FS="="}{print $2}' | \
>   sed 's/[	 ]//g' | tr "A-Z" "a-z"
> 

Hmmm... I think that Configure doesn't allow whitespace before the
Module lines. To be consistant, I don't think CutRule should either.
I would prefer, however, both allowing whitespace in front :)
-- 
====================================================================
      Jim Jagielski            |       jaguNET Access Services
     jim@jaguNET.com           |       http://www.jaguNET.com/
                  "Not the Craw... the CRAW!"

Mime
View raw message