httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: lingerout()
Date Mon, 14 Apr 1997 20:46:34 GMT
I tried reading buff.c and got a big headache... I just took
your message at face value about things being in a "really screwed
state".

Dean Gaudet wrote:
> 
> No they're not really screwed up, they're just in a state where it'd be
> hard to clean up and return EINTR to the caller.  You see EINTR isn't
> always a bad thing, at least not in the general case.  EINTR just says the
> call was interrupted and should be restarted... and that's exactly what
> buff.c does. 
> 
> On Mon, 14 Apr 1997, Jim Jagielski wrote:
> 
> > Dean Gaudet wrote:
> > > 
> > > On Sun, 13 Apr 1997, Roy T. Fielding wrote:
> > > > Hmmmm, the calls to shutdown, select, and read cannot be restarted and
> > > > the first EINTR will cause the lingering to end.  Ah crap, the place
> > > > where it might occur is in bflush(), where it is looping on EINTR instead
> > > > of returning with -1.  I can't think of any case where we would want
> > > > a flush to continue after a signal is received, so I think that is bogus.
> > > 
> > > Good luck fixing this... if you have an interrupted syscall anywhere
> > > in buff.c things are in a really screwed state (consider chunking)
> > > and cleanup is hard to do, which is why it's written to just continue.
> > > 
> > 
> > I'm sure there must be a reason, but I'm missing it: Why, if things
> > are really screwed up in buff.c, do we not return an error? Surely
> > continuing won't make things better.
> > 
> > -- 
> > ====================================================================
> >       Jim Jagielski            |       jaguNET Access Services
> >      jim@jaguNET.com           |       http://www.jaguNET.com/
> >                   "Not the Craw... the CRAW!"
> > 
> 


-- 
====================================================================
      Jim Jagielski            |       jaguNET Access Services
     jim@jaguNET.com           |       http://www.jaguNET.com/
                  "Not the Craw... the CRAW!"

Mime
View raw message