Received: by taz.hyperreal.com (8.8.4/V2.0) id QAA17111; Sun, 16 Mar 1997 16:22:35 -0800 (PST) Received: from twinlark.arctic.org by taz.hyperreal.com (8.8.4/V2.0) with SMTP id QAA17103; Sun, 16 Mar 1997 16:22:32 -0800 (PST) Received: (qmail 5301 invoked by uid 500); 17 Mar 1997 00:24:18 -0000 Date: Sun, 16 Mar 1997 16:24:18 -0800 (PST) From: Dean Gaudet To: Apache Developer ML Subject: Re: config/234: REMOTE_IDENT not always available to mod_rewrite (fwd) In-Reply-To: <199703161530.QAA15414@en1.engelschall.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@hyperreal.com I just walked through the code up to the call to hook_uri2file and dir_conf->do_rfc1413 is properly set. Something else is going on here... Dean On Sun, 16 Mar 1997, Ralf S. Engelschall wrote: > Hello Marc Slemko, in a previous mail you wrote: > > > In case you don't follow the bugs list... > > Thanks for the hint. > > > Subject: config/234: REMOTE_IDENT not always available to mod_rewrite > > > >[...] > > >Fix: > > The problem shows itself in get_remote_login(), http_core.c, line 396: > > > > if (dir_conf->do_rfc1413 & 1) > > return rfc1413(r->connection, r->server); > > else > > return NULL; > > > > When get_remote_login() is called from mod_rewrite.c, line 2532, it > > always returns NULL. Apparently dir_conf->do_rfc1413 hasn't been set > > from the virtual host's IdentityCheck directive yet > > >Audit-Trail: > > >Unformatted: > > Because get_remote_logname() actually only calls rfc1413() if > r->connection->remote_logname is not set, I've just replaced the > get_remote_logname() call in mod_rewrite by the code segment > > if (r->connection->remote_logname != NULL) > result = r->connection->remote_logname; > else > result = rfc1413(r->connection, r->server); > > This will be included in my next patch to mod_rewrite because I've currently > incorporated a simple but essential comparison feature to mod_rewrite's > RewriteCond directive for time-dependend rewrite rules. Will be submitted > recently. > > Greetings, > Ralf S. Engelschall > rse@engelschall.com > www.engelschall.com >