Received: by taz.hyperreal.com (8.8.4/V2.0) id KAA20738; Sun, 16 Mar 1997 10:27:18 -0800 (PST) Received: from Master by taz.hyperreal.com (8.8.4/V2.0) with SMTP id KAA20734; Sun, 16 Mar 1997 10:27:16 -0800 (PST) Date: Sun, 16 Mar 1997 13:20:36 -0500 Message-Id: <97031613203636@decus.org> From: coar@decus.org (Rodent of Unusual Size) To: New-HTTPd@hyperreal.com, Coar@topaz.decus.org Subject: Re: config/234: REMOTE_IDENT not always available to mod_rewrite (fwd) X-VMS-To: NH X-VMS-Cc: COAR Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@hyperreal.com >From the fingers of Ralf S. Engelschall flowed the following: > >Because get_remote_logname() actually only calls rfc1413() if >r->connection->remote_logname is not set, I've just replaced the >get_remote_logname() call in mod_rewrite by the code segment > > if (r->connection->remote_logname != NULL) > result = r->connection->remote_logname; > else > result = rfc1413(r->connection, r->server); Um.. get_remote_logname calls rfc1413() only if r->connection->remote_logname is NULL *and* if RFC1413 checking is supposed to be done. It looks like the above patch is going to cause mod_rewrite to call rfc1413() unconditionally, because you don't (and really can't) check for the presence of IdentityCheck the way get_remote_logname does. So mod_rewrite will incur the overhead of RFC1413 processing even if the server configuration doesn't call for it. Or am I missing something? #ken :-/}