Received: by taz.hyperreal.com (8.8.4/V2.0) id EAA27513;
 Thu, 6 Mar 1997 04:47:45 -0800 (PST)
Received: from shado.jaguNET.com by taz.hyperreal.com (8.8.4/V2.0) with ESMTP
 id EAA27498; Thu, 6 Mar 1997 04:47:40 -0800 (PST)
Received: (from jim@localhost) by shado.jaguNET.com (8.8.5/jag-2.4) id
 HAA17132 for new-httpd@hyperreal.com; Thu, 6 Mar 1997 07:47:37 -0500 (EST)
From: Jim Jagielski <jim@jaguNET.com>
Message-Id: <199703061247.HAA17132@shado.jaguNET.com>
Subject: Re: [PATCH] file descriptor leak
To: new-httpd@hyperreal.com
Date: Thu, 6 Mar 1997 07:47:36 -0500 (EST)
In-Reply-To: <Pine.LNX.3.95dg2.970306041125.6067B-100000@twinlark.arctic.org>
 from "Dean Gaudet" at Mar 6, 97 04:14:27 am
X-Mailer: ELM [version 2.4 PL25]
Content-Type: text
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@hyperreal.com

Dean Gaudet wrote:
> 
> It hasn't been bpushfd() yet at that point, although it has been noted for
> cleanup... hmm.

Hmm is right :/

> 
> Yeah ya know, this doesn't look necessary.  The continue is going to lead
> to a clear_pool that should clean it up.
> 
> Dean
> 
> On Thu, 6 Mar 1997, Jim Jagielski wrote:
> 
> > Shouldn't we use bclose()?
> > 
> > Dean Gaudet wrote:
> > > 
> > > 
> > > Yep this fixes a file descriptor leak.  Patch included.
> > > 
> > > Dean
> > > 
> > > Index: http_main.c
> > > ===================================================================
> > > RCS file: /export/home/cvs/apache/src/http_main.c,v
> > > retrieving revision 1.127
> > > diff -c -3 -r1.127 http_main.c
> > > *** http_main.c	1997/03/04 21:44:38	1.127
> > > --- http_main.c	1997/03/06 07:29:22
> > > ***************
> > > *** 1735,1740 ****
> > > --- 1735,1741 ----
> > >   	clen = sizeof(sa_server);
> > >   	if (getsockname(csd, &sa_server, &clen) < 0) {
> > >   	    log_unixerr("getsockname", NULL, NULL, server_conf);
> > > + 	    close(csd);
> > >   	    continue;
> > >   	}
> > >   
> > > 
> > 
> > 
> > -- 
> > ====================================================================
> >       Jim Jagielski            |       jaguNET Access Services
> >      jim@jaguNET.com           |       http://www.jaguNET.com/
> >                   "Not the Craw... the CRAW!"
> > 
> 


-- 
====================================================================
      Jim Jagielski            |       jaguNET Access Services
     jim@jaguNET.com           |       http://www.jaguNET.com/
                  "Not the Craw... the CRAW!"