httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] file descriptor leak
Date Thu, 06 Mar 1997 12:14:27 GMT
It hasn't been bpushfd() yet at that point, although it has been noted for
cleanup... hmm.

Yeah ya know, this doesn't look necessary.  The continue is going to lead
to a clear_pool that should clean it up.

Dean

On Thu, 6 Mar 1997, Jim Jagielski wrote:

> Shouldn't we use bclose()?
> 
> Dean Gaudet wrote:
> > 
> > 
> > Yep this fixes a file descriptor leak.  Patch included.
> > 
> > Dean
> > 
> > Index: http_main.c
> > ===================================================================
> > RCS file: /export/home/cvs/apache/src/http_main.c,v
> > retrieving revision 1.127
> > diff -c -3 -r1.127 http_main.c
> > *** http_main.c	1997/03/04 21:44:38	1.127
> > --- http_main.c	1997/03/06 07:29:22
> > ***************
> > *** 1735,1740 ****
> > --- 1735,1741 ----
> >   	clen = sizeof(sa_server);
> >   	if (getsockname(csd, &sa_server, &clen) < 0) {
> >   	    log_unixerr("getsockname", NULL, NULL, server_conf);
> > + 	    close(csd);
> >   	    continue;
> >   	}
> >   
> > 
> 
> 
> -- 
> ====================================================================
>       Jim Jagielski            |       jaguNET Access Services
>      jim@jaguNET.com           |       http://www.jaguNET.com/
>                   "Not the Craw... the CRAW!"
> 


Mime
View raw message