httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@gonzo.ben.algroup.co.uk>
Subject Re: Patch vote
Date Sat, 15 Mar 1997 18:16:08 GMT
Jim Jagielski wrote:
> 
> Comments or votes:
> Index: apache/src/http_main.c
> ===================================================================
> RCS file: /export/home/cvs/apache/src/http_main.c,v
> retrieving revision 1.128
> diff -c -r1.128 http_main.c
> *** http_main.c	1997/03/11 06:04:39	1.128
> --- http_main.c	1997/03/15 17:25:46
> ***************
> *** 991,998 ****
>       int res = 0;
>   
>       for (i = 0; i < HARD_SERVER_LIMIT; ++i)
> ! 	if (scoreboard_image->servers[i].status == SERVER_READY
> ! 	  || scoreboard_image->servers[i].status == SERVER_STARTING)
>   	    ++res;
>   
>       return res;
> --- 991,997 ----
>       int res = 0;
>   
>       for (i = 0; i < HARD_SERVER_LIMIT; ++i)
> ! 	if (scoreboard_image->servers[i].status == SERVER_READY)
>   	    ++res;

I'm suspicious of this change - wouldn't it mean that servers could be spawned
without limit on heavily loaded systems (well, up to HARD_SERVER_LIMIT)?

Cheers,

Ben.

-- 
Ben Laurie                Phone: +44 (181) 994 6435  Email: ben@algroup.co.uk
Freelance Consultant and  Fax:   +44 (181) 994 6472
Technical Director        URL: http://www.algroup.co.uk/Apache-SSL
A.L. Digital Ltd,         Apache Group member (http://www.apache.org)
London, England.          Apache-SSL author

Mime
View raw message