httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roy T. Fielding" <field...@kiwi.ICS.UCI.EDU>
Subject Re: [PATCH] PR#212: error trying to resolve 255.255.255.255
Date Fri, 07 Mar 1997 12:24:30 GMT
+1 iff you use a variable name more meaningful than "i" for
the boolean tests.  I have my limits ...

....Roy

>--- 871,894 ----
>  	*t = 0;
>      }
>  
>+     i = 0;
>      if (strcmp(w, "*") == 0) {
>! 	my_addr = htonl(INADDR_ANY);
>! 	i = 1;
>!     } else if( strcmp(w, "_default_") == 0
>! 	    || strcmp(w, "255.255.255.255") == 0 ) {
>! 	my_addr = DEFAULT_VHOST_ADDR;
>! 	i = 1;
>!     } else if(
>  #ifdef DGUX
>! 	    ( my_addr = inet_network(w) )
>  #else
>! 	    ( my_addr = inet_addr(w) )
>  #endif
>! 	    != INADDR_NONE ) {
>! 	i = 1;
>!     }
>!     if( i ) {
>  	sar = pcalloc( p, sizeof( server_addr_rec ) );
>  	**paddr = sar;
>  	*paddr = &sar->next;
>


Mime
View raw message