httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chuck Murcko <ch...@topsail.org>
Subject Re: memory management goof in alloc.c (fwd)
Date Sun, 09 Mar 1997 20:42:27 GMT
Works nicely here. +1.

Randy Terbush wrote:
> 
> +1
> 
> > >    if (arr->nelts == arr->nalloc) {
> > >!     int new_size = arr->nalloc * 2;
> > >!     char *new_data;
> > >!
> > >!     if (new_size == 0) ++new_size;
> > >!
> > >!     new_data = pcalloc (arr->pool, arr->elt_size * new_size);
> >
> > In principle the patch is good, but I don't like the way it
> > sets new_size and then increments it.  That bit of uglyness was
> > inherited from the other function, but I'd prefer to fix both
> > as in the following patch.
> >
-- 
chuck
Chuck Murcko
The Topsail Group, West Chester PA USA
chuck@topsail.org

Mime
View raw message