httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@engelschall.com (Ralf S. Engelschall)
Subject Re: [PATCH] Re: general/276: SERVER_PORT variable is negative
Date Sat, 29 Mar 1997 16:16:01 GMT

In article <97032716251642@decus.org> you wrote:
> From the fingers of Thomas Hall flowed the following:
> >
> >When running a test cgi, I noticed that the SERVER_PORT variable was negative.
>     8< snip
> >I think that you are using a signed short when you should have an unsigned short.

>     Ouch!  Right he is.  The following patch fixes this for my CGI tests
>     and compiles cleanly on OSF/1.  However, it's a fairly basic change;
>     anyone see any drawbacks?

>     I noticed that these two cells have counterparts in mod_rewrite,
>     too, so Ralf might want to track the change there if voted in.
>[...]
> !     short host_port;            /* The bound port, for this server */   
> !     unsigned short host_port;   /* The bound port, for this server */   
>[...]

+1

I've also incorporated this into mod_rewrite 3.0.3. Thanks for the hint.

Greetings,
                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com

Mime
View raw message