httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Terbush <ra...@zyzzyva.com>
Subject Re: [PATCH] Re: config/234: REMOTE_IDENT not always available to mod_rewrite
Date Tue, 18 Mar 1997 23:13:26 GMT

+1


> Michael, it looks like there was definately a bug and not just the
> ambiguity I thought originally.  Please try the patch at the bottom. 
> 
> To new-httpd: Earlier on in read_request() it defaults r->per_dir_config =
> r->server->lookup_defaults, but at that point r->server is the ip-based
> match (which in Michael's case would be the main_server).  After
> check_hostalias or check_serverpath we may have switched to a different
> vhost.  Now without this patch below the server would go through
> location_walk() then translate_name() and finally at the top of
> directory_walk() it would inherit the correct per_dir_config.  mod_rewrite
> does its thing during translate_name() so it was still running with the
> wrong config. 
> 
> Dean
> 
> Index: http_protocol.c
> ===================================================================
> RCS file: /export/home/cvs/apache/src/http_protocol.c,v
> retrieving revision 1.107
> diff -c -3 -r1.107 http_protocol.c
> *** http_protocol.c	1997/03/07 14:43:52	1.107
> --- http_protocol.c	1997/03/17 08:42:48
> ***************
> *** 756,761 ****
> --- 756,764 ----
>         check_hostalias(r);
>       else
>         check_serverpath(r);
> +     
> +     /* we may have switched to another server */
> +     r->per_dir_config = r->server->lookup_defaults;
>   
>       kill_timeout (r);
>       conn->keptalive = 0;   /* We now have a request - so no more short timeouts
*/




Mime
View raw message