Received: by taz.hyperreal.com (8.8.4/V2.0) id OAA02634; Fri, 7 Feb 1997 14:02:08 -0800 (PST) Received: from fully.organic.com by taz.hyperreal.com (8.8.4/V2.0) with ESMTP id OAA02621; Fri, 7 Feb 1997 14:02:04 -0800 (PST) Received: (from ed@localhost) by fully.organic.com (8.8.3/8.6.12) id WAA16158 for new-httpd@hyperreal.com; Fri, 7 Feb 1997 22:03:28 GMT From: "Ed Korthof" Message-Id: <9702071403.ZM16156@fully.organic.com> Date: Fri, 7 Feb 1997 14:03:27 -0800 In-Reply-To: Marc Slemko "my version of the mod_include outbut buffering" (Feb 6, 11:18pm) References: X-Mailer: Z-Mail (3.2.0 26oct94 MediaMail) To: new-httpd@hyperreal.com Subject: Re: my version of the mod_include outbut buffering Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@hyperreal.com I'm not particularly invested in my patch for mod_include (and I just realized, so I'll remove it from the running. However, I would suggest a few changes to Marc's patch, specifically to avoid having the change the other functions which use GET_CHAR. IMO, changing the arguments they take is something we should avoid. Marc, why don't we use the GET_CHAR, PUT_CHAR, and FLUSH_BUFFER macros you posted -- define them above find_string -- and undef them below find_string; then define the old GET_CHAR macro for use by the other functions? Not the cleanest code, but it should do the job efficiently. -- -- Ed Korthof | Web Server Engineer -- -- ed@organic.com | Organic Online, Inc -- -- (415) 278-5676 | Fax: (415) 284-6891 --