httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject [PATCH] PR#161 -- mod_dir performance with negotiation
Date Thu, 20 Feb 1997 07:16:20 GMT
+1 on the response number cleanup and the end search of index file.  But
the fast redirection didn't compile cleanly for me under gcc -Wall, and
I'm kind of concerned about the code maintenance aspects of inlining
process_request_internal() like that.  If you can work around it, that'd
be great. 

Dean

---------- Forwarded message ----------
Date: Wed, 19 Feb 1997 19:35:42 +0100 (MET)
From: Petr Lampa <lampa@fee.vutbr.cz>
To: Dean Gaudet <dgaudet@arctic.org>
Subject: Re: [STATUS] close to 1.2b7 (fwd)



Here are some fixes:

>   * Questionable performace of  mod_dir() with negotiation
> 	PR#161

mod_dir.diff: 3 changes
	- replace protocol response numbers with symbols
	- fast redirection (inlined end of process_request_internal())
	- end search of index file if MULTIPLE_CHOICES or HTTP_NOT_ACCEPTABLE 
	  and return with proper headers from content negotiation
          (not reported yet - mod_dir didn't pass Vary: headers).
	
Fast redirection is questionable - it duplicates code from http_request.c
If this change would not be acceptable, I'll make simpler fix to
work around only the problem with passing of negotiation headers.


[...]

All changes were tested&debugged.

							Petr Lampa

-- 
Department of Computer Science and Engineering  E-mail: lampa@fee.vutbr.cz
Faculty of El. Engineering and Comp. Science	Phone: (+42 5) 7275/225,111
Technical University of Brno			Fax:  (+42 5) 41211141
Bozetechova 2, 612 66 Brno, Czech Republic

Mime
View raw message