httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: ack re: [PATCH] performance improvement
Date Sun, 02 Feb 1997 03:35:18 GMT
On Sat, 1 Feb 1997, Rob Hartill wrote:

> On Sat, 1 Feb 1997, Dean Gaudet wrote:
> 
> > +1
> > 
> > On Fri, 31 Jan 1997, Ed Korthof wrote:
> > 
> > > Yes, I realized that. <blush> Well, without that, the patch appears to
> > > work fine -- I'm going to be doing more tests today, since we need to
> > > improve performance, and this seems one place to start.  Anyway, the
> > > attached patch has less effective error reporting, but I can't get
> > > log_printf working w/ this macro, so...
> 
> Can someone resend the fixed patch. I missed it somehow.


*** mod_include.c	Fri Jan 31 09:53:20 1997
--- mod_include.c.orig	Fri Jan 31 09:45:28 1997
***************
*** 116,125 ****
  #define GET_CHAR(f,c,r,p) \
   { \
     int i = getc(f); \
!    if (i == EOF) { /* either EOF or error--needs error handling if latter */ \
!         if (ferror(f)) \
!             fprintf(stderr, \
!                     "encountered error in GET_CHAR macro, mod_include.\n"); \
          pfclose(p,f); \
          return r; \
     } \
--- 116,122 ----
  #define GET_CHAR(f,c,r,p) \
   { \
     int i = getc(f); \
!    if(feof(f) || ferror(f) || (i == -1)) { \
          pfclose(p,f); \
          return r; \
     } \


Mime
View raw message