httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marc Slemko <ma...@znep.com>
Subject Re: [PATCH] Big fixes to main loop, lingering_close
Date Sun, 16 Feb 1997 01:40:39 GMT
On Sat, 15 Feb 1997, Roy T. Fielding wrote:

[...]
> Needless to say, this section of code is critical, and this patch needs
> serious review ASAP.  It may fix several reported problems, including
> missing status updates, graceful restarts, leaking file descriptors,
> and lingering_close.  OTOH, it may fix none of them, but it will be
> worth it just to improve readability.

+1.  Like Roy, I'm not certain it will fix anything but if it doesn't fix
anything that's just because we were lucky before.

This should be tested by people both with and without listeners.  I have
gone through a line-by-line comparison with the old code and could
not find any new bugs.

> 
> Regarding Marc's earlier question, I think FNDELAY is portable to any
> system that implements sockets.  If it isn't, then we can add ifdefs,
> but we can't just remove the non-blocking (we must replace it with the
> local equivalent, or set NO_LINGCLOSE).

If we need to set it non-blocking, no point in doing anything now.

I'm not sure that it neccesarily hurts _that_ much for the average (ie.
low volume) server if we can't set the socket non-blocking, but it is
safter to leave as is for now.  If we get problems with systems that don't
support it or any other method, then we need to figure out what to do.



Mime
View raw message